Replace the eventsource library
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcarl
reviewed
Mar 1, 2019
| './node_modules/event-source-polyfill/src/eventsource.min.js' | ||
| ) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Diff is tricky to read, it looks like this is the only change? 👍 on removing polyfill
vcarl
reviewed
Mar 1, 2019
src/call_builder.js
Outdated
| @@ -1,14 +1,13 @@ | |||
| import forEach from 'lodash/forEach'; | |||
| import URI from 'urijs'; | |||
| import URITemplate from 'urijs/src/URITemplate'; | |||
| import { NativeEventSource, EventSourcePolyfill } from 'event-source-polyfill'; | |||
There was a problem hiding this comment.
AFAIK it's generally best practice to ask consumers to provide polyfills for web standards rather than pulling them in as dependencies. That would be a breaking change so I don't think we should make it willy-nilly, but at some point it might be better to rely on window.EventSource and just provide a warning if it's missing.
|
The polyfill doesn't appear to work with the current codebase in the same way that the old one did. Looking into it. |
added 6 commits
March 5, 2019 17:12
bartekn
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only load
eventsource, which uses node built-inshttpandhttps`, in Node. Fixes an issue with Angular 6. See stellar/js-stellar-base#128.